[Data Views]: Add drop down with action in headers #55293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
ntsekouras
requested review from
youknowriad,
oandregal,
jameskoster and
SaxonF
|
Size Change: +512 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Oct 12, 2023
| @@ -183,40 +207,10 @@ function SortMenu( { dataView } ) { | |||
| } | |||
| side="left" | |||
| > | |||
| { Object.entries( sortingItemsInfo ).map( | |||
There was a problem hiding this comment.
Is the change in this file necessary. Asking because I'm updating this code in #55294
What was changed exactly here?
There was a problem hiding this comment.
I'm guessing you just want to reuse the "submenu" for a field in the other PR. I think we need to choose between:
- Not reusing this component and just duplicating it because one can be independent from tanstack but the other should not.
- Reusing the one that is not dependent on tanstack.
But since the parent components of both have different requirements, I might think that it's better to not reuse here.
There was a problem hiding this comment.
I'm just reusing the sort option menu items that are identical in terms of UI. I get the refactoring in your PR, but I don't get how they are different. The both depend on the view config. Maybe the could live in a different file? 🤔
There was a problem hiding this comment.
The reusable thing is menu items but the whole menu is different which makes me think it's a bit weird to reuse but it's fine. I can handle that. I changed the props of the component (not use dataView object)
There was a problem hiding this comment.
I mean, it's an easy update to duplicate or reuse and change approach later on. I have no strong opinions. Maybe we should land your PR first and see then. Though I don't think it makes much difference at this point. What do you think?
There was a problem hiding this comment.
Yeah, I'm not too concerned either, whatever lands first is fine :)
youknowriad
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #55083
This PR adds a drop down menu in headers with sorting and hide field actions based on the following design:
Testing Instructions